Let setInputCloud of search methods indicate success or failure #5840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of returning nothing, return true on success and false on failure. This is especially useful for organized neighbor to indicate whether the input cloud is suitable, but might also come in handy for other methods in the future. In filters, use the returned value to abort in case of failure. Fixes PointCloudLibrary#5819
|
looks reasonable to me. |
|
Its public API right? So don't we need to keep the old version still around and deprecate it? Besides that, looks good 👍 |
|
What kind of compiler warning do you mean? As long as we don't mark this with |
Hmm, not sure there is any warnings about this - just more less thought there would be, but seems not. 👍 |
|
@larshg So is that an approval? 😄 |
larshg
approved these changes
Oct 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of returning nothing, return true on success and false on failure. This is especially useful for organized neighbor to indicate whether the input cloud is suitable, but might also come in handy for other methods in the future. In filters, use the returned value to abort in case of failure. Fixes #5819